Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ceph: use lib.meta.availableOn instead of meta.available #247414

Merged
merged 1 commit into from Aug 28, 2023
Merged

ceph: use lib.meta.availableOn instead of meta.available #247414

merged 1 commit into from Aug 28, 2023

Conversation

ghost
Copy link

@ghost ghost commented Aug 5, 2023

Description of changes

pkg.meta.available does not distinguish between the buildPlatform and the hostPlatform.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 23.11 Release Notes (or backporting 23.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

ceph: use availableOn instead of meta.available
dc028fd 
pkg.meta.available is deprecated (see subsequent commit which adds a
warning) and does not distinguish between the buildPlatform and the
hostPlatform.
@ghost ghost marked this pull request as ready for review August 5, 2023 23:32
@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux labels Aug 6, 2023
Artturin
Artturin approved these changes Aug 28, 2023
View reviewed changes
Copy link
Member

@Artturin Artturin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No hash change

@Artturin Artturin merged commit 9815bda into NixOS:master Aug 28, 2023
10 checks passed
@ghost ghost deleted the pr/meta.availableOn/ceph branch October 22, 2023 11:37
@Artturin Artturin mentioned this pull request Jan 29, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@Artturin